• MoSal@programming.dev
    link
    fedilink
    arrow-up
    4
    ·
    14 hours ago
    // Don't bail on the first error, but remember the worst one.
    let mut worst = 0;
    for file in files {
        if let Err(e) = chmod_one(file) {
            worst = worst.max(e.exit_code());
        }
    }
    process::exit(worst);
    

    This is not rustic, I feel.

    files.iter()
      .map(chmod_one)
      .filter_map(Result::err)
    

    is more like it.

    From there, you can next() for first error, last() for last error, or fold() for max error, or collect() if you need to save all errors.


    And no, static compilation doesn’t help here, because get_user_by_name goes through NSS, which dlopens libnss_* modules at runtime regardless of whether your binary is statically linked.

    This is not true in musl systems. I just quickly checked in a Chimera rootfs (which has a system dynamic musl libc btw).

    I believe the described dlopening is one of the well known reasons why GNU libc is not suitable for static linking, unlike musl!

    In Arch, this indeed loads /usr/lib/libnss_systemd.so.2.

    Everyone can test this with strace id 2>&1 | egrep 'open.*\.so'.

  • Mihies@programming.dev
    link
    fedilink
    arrow-up
    8
    ·
    23 hours ago

    Rust or any other compiler can’t catch those type of bugs because they are not bugs at compiler level 🤷

    • Tobias Hunger@programming.dev
      link
      fedilink
      arrow-up
      6
      ·
      21 hours ago

      We said the same about memory safety: That’s something a compiler can not solve. Now it does.

      It is nice to see that sometines things do improve.

      • davidgro@lemmy.world
        link
        fedilink
        arrow-up
        3
        ·
        19 hours ago

        I thought one of the goals of Java and similar was partial memory safety? If it didn’t have null it seems it would be most of the way there.

        And don’t forget Basic. Yeah most variants had pointers and equivalents to null, but they are ‘advanced’ and not meant for general code. (Although that’s interpreted and you said compiled, often it could be ‘complied’ similarly to Java bytecode)

        • Peter Horvath@mastodon.de
          link
          fedilink
          arrow-up
          2
          ·
          19 hours ago

          @davidgro @hunger Last basic variant I worked with was the basic of the commodore machines. It had no NULL. I have also seen vbscript a little, afaik also it had not.

          In Java, null does not mean a real 0 value, I think it is more like a static const, more similar to the None type of the Python. Its name is only a helper for the C/C++ guys to better understand a stack trace.

          • davidgro@lemmy.world
            link
            fedilink
            arrow-up
            1
            ·
            17 hours ago

            Ah, yeah looks like address 0 is nothing special on C64. I was thinking more about things like Qbasic and especially Visual Basic where dereferencing address 0 expecting a string or object is easy enough to do.

          • davidgro@lemmy.world
            link
            fedilink
            arrow-up
            1
            ·
            17 hours ago

            I can’t claim to have learned them well, but I have used Java and various Basics over the last 30+ years.

            Which parts of my comment do you disagree with?

            • Khleedril@cyberplace.social
              link
              fedilink
              arrow-up
              0
              ·
              17 hours ago

              @davidgro The way that #Rust guards memory is completely different to the way Java or Basic does. Rust is a fully compiled language suitable for systems programming, and the memory protection all happens at compile time; the runtime actually gains speed through the compilation process, rather than having the memory protection slow it down.

              The real difference is that the Rust compiler actually reads into the code it is compiling, rather than just making a mechanical translation.

              • davidgro@lemmy.world
                link
                fedilink
                arrow-up
                1
                ·
                16 hours ago

                That’s true, it is a very different paradigm.
                I wouldn’t go so far as to say that nobody thought it possible before Rust, but I agree it’s much more effective and performant.

      • Mihies@programming.dev
        link
        fedilink
        English
        arrow-up
        1
        ·
        19 hours ago

        Memory safety is something compiler understands and has under control, this stuff it does not. Nor it should.

        • TehPers@beehaw.org
          link
          fedilink
          English
          arrow-up
          2
          ·
          18 hours ago

          Many of their TOCTOU issues are something a type system can help with. Require operations to execute on a fd handle directly rather than using convenience functions.

          let fd = FileDescriptor::new(path);
          fd.delete()?;
          fd.create(mode)?;
          
          let is_root = fd == FileDescriptor::new("/"); // does (dev, inode) comparison internally
          // etc
          

          The uutils devs would need to create that themselves, but OpenOptions seems to get them part of the way there at least.

          • BB_C@programming.dev
            link
            fedilink
            arrow-up
            2
            ·
            14 hours ago

            That’s a question of API, not type system. And FD types (e.g. OwnedFd, BorrowedFd) are already in std.

            • TehPers@beehaw.org
              link
              fedilink
              English
              arrow-up
              1
              ·
              9 hours ago

              That’s a question of API, not type system.

              It’s only enforced because of Rust’s strict type system. Python, on the other hand, lets you do whatever you want by comparison, and complains only at runtime. I’ve seen far too many **kwargs for my liking.

              And FD types (e.g. OwnedFdBorrowedFd) are already in std.

              My example would be a thin wrapper around these, most likely. It’s only an example of what I’m trying to convey, though.

  • Digit@lemmy.wtf
    link
    fedilink
    English
    arrow-up
    1
    ·
    19 hours ago

    Time for Haskell?

    How many more bugs would Haskell catch?

    “Entire classes of bugs”?